Patch set 1:Code-Review -1
View Change
1 comment:
File ichspi.c:
Patch Set #1, Line 850: timeout = 100 * 60; /* 60 ms are 9.6 million cycles at 16 MHz. */
You're still hitting this timeout for every SPI flash chip, even if you don't see the message. Something should indicate that your hardware has the SPI controller in a non-working state, so the proper fix would be to mask the SPI capabilities in that case.
To view, visit change 40328. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0795653bd9ababccf666ed8af0c9bff22853371d
Gerrit-Change-Number: 40328
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Wed, 15 Apr 2020 10:29:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment