Attention is currently required from: Bora Guvendik, DZ, Nikolai Artemiev, Stefan Reinauer, Subrata Banik.
Anastasia Klimchuk has posted comments on this change by Bora Guvendik. ( https://review.coreboot.org/c/flashrom/+/82626?usp=email )
Change subject: flashchips: add support for MX77U51250F chip
......................................................................
Patch Set 3:
(3 comments)
Patchset:
PS3:
OK, I will review this patch in next week.
Thank you so much for your help! I will close this comment thread.
PS3:
Yes I was asking in the other comment earlier, if it's possible to send datasheet to me (e.g. […]
I am closing this comment thread, since the review is now in progress.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/82626/comment/af24a885_9210826f?usp... :
PS3, Line 11620: .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA,
There is only one status register in this Flash. So, it doesn't need to define the […]
Thank you for explanation! I see, no need for any of FEATURE_WRSR2 or FEATURE_WRSR3 etc.
It's a good idea to add `FEATURE_CFGR` anyway, but if reg_bits need configuration register then it would be required to add `FEATURE_CFGR`.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/82626?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I2c2e94f01dc63f60cf636bc6afe1f033e2a6f83c
Gerrit-Change-Number: 82626
Gerrit-PatchSet: 3
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: DZ
danielzhang@mxic.com.cn
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: DZ
danielzhang@mxic.com.cn
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Mon, 22 Jul 2024 09:29:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bora Guvendik
bora.guvendik@intel.com
Comment-In-Reply-To: DZ
danielzhang@mxic.com.cn
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org