Attention is currently required from: Bora Guvendik, DZ, Nikolai Artemiev, Stefan Reinauer, Subrata Banik.

View Change

3 comments:

• Patchset:

  • Patch Set #3:

    OK, I will review this patch in next week.

    Thank you so much for your help! I will close this comment thread.

  • Patch Set #3:

    Yes I was asking in the other comment earlier, if it's possible to send datasheet to me (e.g. […]

    I am closing this comment thread, since the review is now in progress.

• File flashchips.c:

  • Patch Set #3, Line 11620: .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA,

    There is only one status register in this Flash. So, it doesn't need to define the […]

    Thank you for explanation! I see, no need for any of FEATURE_WRSR2 or FEATURE_WRSR3 etc.

    It's a good idea to add `FEATURE_CFGR` anyway, but if reg_bits need configuration register then it would be required to add `FEATURE_CFGR`.

To view, visit change 82626. To unsubscribe, or for help writing mail filters, visit settings.