[M] Change in flashrom[main]: libflashrom: Add API to return the list of supported programmers

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: Dmitry Zhadinets.

Anastasia Klimchuk has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86921?usp=email )

Change subject: libflashrom: Add API to return the list of supported programmers
......................................................................

Patch Set 3:

(5 comments)

Patchset:

PS3:
> I will wait the merge of log API merge to rebase it because I will have conflicts in test/libflashro […]

I realised that by now I already added comments to all three patches in the chain, hope it's fine. If you re-arrange the code between commits, comment can be "replied" in the other commit from where it was asked, it's fine.

I am mostly thinking / worried about a comment in CB:86946 because it seems like it should be v2 probing doing this.

File libflashrom.c:

https://review.coreboot.org/c/flashrom/+/86921/comment/ff1707a8_7d6246bf?usp... :
PS3, Line 147:  
no space here

https://review.coreboot.org/c/flashrom/+/86921/comment/886fd2df_5d72935b?usp... :
PS3, Line 159: const char *flashrom_get_programmer_name(int n)
             : {
             : 	if (n < 0 || (size_t)n >= programmer_table_size)
             : 		return NULL;
             : 	return programmer_table[n]->name;
             : }
Why this is needed? Client can get the n-th name using the function just above `flashrom_supported_programmers` and then loop on top of it?

File tests/libflashrom.c:

https://review.coreboot.org/c/flashrom/+/86921/comment/c4f3c060_74462418?usp... :
PS3, Line 40: #if CONFIG_DUMMY == 1
For tests, dummy is always included, you can remove this check

https://review.coreboot.org/c/flashrom/+/86921/comment/0aa4163f_c7fd656f?usp... :
PS3, Line 62:     
This needs to be tabs (instead of spaces).