Attention is currently required from: Dmitry Zhadinets.
5 comments:
Patchset:
I will wait the merge of log API merge to rebase it because I will have conflicts in test/libflashro […]
I realised that by now I already added comments to all three patches in the chain, hope it's fine. If you re-arrange the code between commits, comment can be "replied" in the other commit from where it was asked, it's fine.
I am mostly thinking / worried about a comment in CB:86946 because it seems like it should be v2 probing doing this.
File libflashrom.c:
no space here
const char *flashrom_get_programmer_name(int n)
{
if (n < 0 || (size_t)n >= programmer_table_size)
return NULL;
return programmer_table[n]->name;
}
Why this is needed? Client can get the n-th name using the function just above `flashrom_supported_programmers` and then loop on top of it?
File tests/libflashrom.c:
Patch Set #3, Line 40: #if CONFIG_DUMMY == 1
For tests, dummy is always included, you can remove this check
This needs to be tabs (instead of spaces).
To view, visit change 86921. To unsubscribe, or for help writing mail filters, visit settings.