Attention is currently required from: Angel Pons, Nikolai Artemiev, Sergii Dmytruk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58483 )
Change subject: writeprotect: add {get,set}_wp_mode()
......................................................................
Patch Set 58: Code-Review+2
(1 comment)
File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/58483/comment/87b8ca29_3a27f0c4
PS58, Line 366: }
General thought: That the positive path comes first in such an if and ?:
can confuse the logical mind, because when enumerating cases usually
(logical) 0 comes first. A table might help, e.g.
static const int wp_mode[][] = {
/* srp=0 srp=1 */
/* srl=0 */ { FLASHROM_WP_MODE_DISABLED, FLASHROM_WP_MODE_HARDWARE },
/* srl=1 */ { FLASHROM_WP_MODE_POWER_CYCLE, FLASHROM_WP_MODE_PERMANENT },
};
--
To view, visit
https://review.coreboot.org/c/flashrom/+/58483
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7b68e940f0e1359281806c98e1da119b4caf8405
Gerrit-Change-Number: 58483
Gerrit-PatchSet: 58
Gerrit-Owner: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Sun, 27 Feb 2022 19:39:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment