Attention is currently required from: Angel Pons, Nikolai Artemiev, Sergii Dmytruk.

Patch set 58:Code-Review +2

View Change

1 comment:

• File writeprotect.c:

  • Patch Set #58, Line 366: }

    General thought: That the positive path comes first in such an if and ?:
    can confuse the logical mind, because when enumerating cases usually
    (logical) 0 comes first. A table might help, e.g.

        static const int wp_mode[][] = {
                    /*           srp=0                         srp=1           */
        /* srl=0 */ { FLASHROM_WP_MODE_DISABLED,    FLASHROM_WP_MODE_HARDWARE  },
        /* srl=1 */ { FLASHROM_WP_MODE_POWER_CYCLE, FLASHROM_WP_MODE_PERMANENT },
        };

To view, visit change 58483. To unsubscribe, or for help writing mail filters, visit settings.