Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61362 )
Change subject: util/ich_descriptors_tool: Invert the meaning of 'dual_output' bit ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/61362/comment/527a52c5_999fd5e8 PS1, Line 7: util/ich_descriptors_tool
nit: I'd use `ich_descriptors.c` as file path, the code is also used by flashrom itself.
Ack
https://review.coreboot.org/c/flashrom/+/61362/comment/a0b240ab_b57e9b06 PS1, Line 11: According to the SPI Programming Guide the dual output is : enabled when this bit is set and disabled if not (checked for Panther : Point, Lewisburg C620, Apollo Lake and Elkhart Lake).
Starting with "According to the SPI Programming Guide" makes it seem like you only checked one SPI p […]
Fine with me, will adapt.