View Change

2 comments:

• Commit Message:

  • Patch Set #1, Line 7: util/ich_descriptors_tool

    nit: I'd use `ich_descriptors.c` as file path, the code is also used by flashrom itself.

    Ack

  • Patch Set #1, Line 11:

    According to the SPI Programming Guide the dual output is
    enabled when this bit is set and disabled if not (checked for Panther
    Point, Lewisburg C620, Apollo Lake and Elkhart Lake).
    

    Starting with "According to the SPI Programming Guide" makes it seem like you only checked one SPI p […]

    Fine with me, will adapt.

To view, visit change 61362. To unsubscribe, or for help writing mail filters, visit settings.