Attention is currently required from: Sam McNally, Edward O'Callaghan, Daniel Campello. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62320 )
Change subject: tests/: Add file path and flags validation to open() calls ......................................................................
Patch Set 14:
(2 comments)
File tests/chip.c:
https://review.coreboot.org/c/flashrom/+/62320/comment/311bd758_ccbea199 PS14, Line 201: io_mock_register(&chip_io); `io_mock_register(&chip_io)` can be moved into `setup_chip`. That would need one more argument for setup_chip, to pass chip_io, because it is not exactly the same for all tests. But at least registration (and de-registration) can be moved to a common place, setup/teardown.
https://review.coreboot.org/c/flashrom/+/62320/comment/f1c26173_6f82bffc PS14, Line 216: io_mock_register(NULL); `io_mock_register(NULL)` can be moved into `teardown` because it just repeats at the end of each test.