Attention is currently required from: Sam McNally, Edward O'Callaghan, Daniel Campello.

View Change

2 comments:

• File tests/chip.c:

  • Patch Set #14, Line 201: io_mock_register(&chip_io);

    `io_mock_register(&chip_io)` can be moved into `setup_chip`. That would need one more argument for setup_chip, to pass chip_io, because it is not exactly the same for all tests. But at least registration (and de-registration) can be moved to a common place, setup/teardown.

  • Patch Set #14, Line 216: io_mock_register(NULL);

    `io_mock_register(NULL)` can be moved into `teardown` because it just repeats at the end of each test.

To view, visit change 62320. To unsubscribe, or for help writing mail filters, visit settings.