Attention is currently required from: Nico Huber, Edward O'Callaghan. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54066 )
Change subject: programmer: Smoothen register_spi_master() API ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
I know about CB:51761. It is focused on the shutdown pointer, though. I still […]
Thanks! Yes, let's add data pointer early. I will do the same for par/opaque and then moving few lines into register_master is internal change, caller won't need to be changed.
Some of my patches still need more work (unresolved comments), not all of them have +2 - not all of them ready to submit anyway. So maybe, if you submit this chain of 2 patches soon, I will rebase?
File spi.c:
https://review.coreboot.org/c/flashrom/+/54066/comment/ad3eb69b_66fd94fe PS1, Line 151: if (data) : rmst.spi.data = data;
You can do it.
Oh great, I will do! I think, would better do it now, before I touched any par master, to get all benefits.
-
Anastasia Klimchuk (Code Review)