Attention is currently required from: Nico Huber, Edward O'Callaghan.
View Change
2 comments:
Patchset:
Patch Set #1:
I know about CB:51761. It is focused on the shutdown pointer, though. I still […]
Thanks! Yes, let's add data pointer early. I will do the same for par/opaque and then moving few lines into register_master is internal change, caller won't need to be changed.
Some of my patches still need more work (unresolved comments), not all of them have +2 - not all of them ready to submit anyway. So maybe, if you submit this chain of 2 patches soon, I will rebase?
File spi.c:
Patch Set #1, Line 151:
if (data)
rmst.spi.data = data;
You can do it.
Oh great, I will do! I think, would better do it now, before I touched any par master, to get all benefits.
To view, visit change 54066. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0c753b3db050fb87d4bbe2301a7ead854f28456f
Gerrit-Change-Number: 54066
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Comment-Date: Wed, 12 May 2021 22:20:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment