Attention is currently required from: Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71579 )
Change subject: programmer: Add pre-init hook ......................................................................
Patch Set 1: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/71579/comment/d73452c3_8f1bb4c3 PS1, Line 9: initalisation Insert an `i` after the first 4 letters: init_i_alisation
https://review.coreboot.org/c/flashrom/+/71579/comment/bccb40f0_d9e240ca PS1, Line 10: either Nit: "either" suggests mutual exclusion which conflicts with the "or both" part at the end. Maybe remove "either"?
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/71579/comment/26c88c90_4c01b8d4 PS1, Line 164: Initialising Very pedantic, buuut... The message for init uses the US spelling of "Initializing", with a `z` instead of an `s`. It would be nice to be consistent.
File include/programmer.h:
https://review.coreboot.org/c/flashrom/+/71579/comment/c4342fbc_d8a80249 PS1, Line 51: struct programmer_cfg *cfg The lack of `const` is intentional, right?
-
Angel Pons (Code Review)