Attention is currently required from: Edward O'Callaghan.

Patch set 1:Code-Review +1

View Change

4 comments:

• Commit Message:

  • Patch Set #1, Line 9: initalisation

    Insert an `i` after the first 4 letters: init_i_alisation

  • Patch Set #1, Line 10: either

    Nit: "either" suggests mutual exclusion which conflicts with the "or both" part at the end. Maybe remove "either"?

• File flashrom.c:

  • Patch Set #1, Line 164: Initialising

    Very pedantic, buuut... The message for init uses the US spelling of "Initializing", with a `z` instead of an `s`. It would be nice to be consistent.

• File include/programmer.h:

  • Patch Set #1, Line 51: struct programmer_cfg *cfg

    The lack of `const` is intentional, right?

To view, visit change 71579. To unsubscribe, or for help writing mail filters, visit settings.