Attention is currently required from: Nico Huber, Angel Pons, Sergii Dmytruk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58480 )
Change subject: flashchips,writeprotect_ranges: add range decoding function ......................................................................
Patch Set 26:
(9 comments)
File flash.h:
https://review.coreboot.org/c/flashrom/+/58480/comment/0db226a5_e7521602 PS23, Line 203: uint32_t
Please don't hard-code fixed-width types. `unsigned int` should work as […]
Done
https://review.coreboot.org/c/flashrom/+/58480/comment/783737c0_70615ed5 PS23, Line 203: typedef
Why have a typedef for it? All the other function pointers in `struct […]
Done
File libflashrom.h:
https://review.coreboot.org/c/flashrom/+/58480/comment/02f29652_11970ecd PS23, Line 134: };
flashrom_flash_getsize() uses `size_t`? Should this follow?
Done
File writeprotect_ranges.c:
https://review.coreboot.org/c/flashrom/+/58480/comment/75f87846_bbf340d6 PS23, Line 19:
Line break, please.
Done
https://review.coreboot.org/c/flashrom/+/58480/comment/0c61a626_01893240 PS23, Line 27: 32
Why 32?
I've changed everything to size_t now, I just defaulted to 32 when I was writing it.
https://review.coreboot.org/c/flashrom/+/58480/comment/a6768340_494a5430 PS23, Line 29: r(
Missing space.
Done
https://review.coreboot.org/c/flashrom/+/58480/comment/545a9ed5_1323e9f7 PS23, Line 34: cfg->bp
Isn't this an implicit pointer? Looks like GCC doesn't warn if compared […]
Amazing, I have no idea this managed to work at all. Thanks for catching it :)
https://review.coreboot.org/c/flashrom/+/58480/comment/12037e4e_5f2e3a69 PS23, Line 50: 4 * 1024
4*KiB
Done
https://review.coreboot.org/c/flashrom/+/58480/comment/d2a36e61_71f780a9 PS23, Line 51: 64 * 1024
64*KiB
Done
-
Nikolai Artemiev (Code Review)