Attention is currently required from: Nico Huber, Angel Pons, Sergii Dmytruk.

View Change

9 comments:

• File flash.h:

  • Patch Set #23, Line 203: uint32_t

    Please don't hard-code fixed-width types. `unsigned int` should work as […]

    Done

  • Patch Set #23, Line 203: typedef

    Why have a typedef for it? All the other function pointers in `struct […]

    Done

• File libflashrom.h:

  • Patch Set #23, Line 134: };

    flashrom_flash_getsize() uses `size_t`? Should this follow?

    Done

• File writeprotect_ranges.c:

  • Patch Set #23, Line 19:

    Line break, please.

    Done

  • Patch Set #23, Line 27: 32

    Why 32?

    I've changed everything to size_t now, I just defaulted to 32 when I was writing it.

  • Patch Set #23, Line 29: r(

    Missing space.

    Done

  • Patch Set #23, Line 34: cfg->bp

    Isn't this an implicit pointer? Looks like GCC doesn't warn if compared […]

    Amazing, I have no idea this managed to work at all. Thanks for catching it :)

  • Patch Set #23, Line 50: 4 * 1024

    4*KiB

    Done

  • Patch Set #23, Line 51: 64 * 1024

    64*KiB

    Done

To view, visit change 58480. To unsubscribe, or for help writing mail filters, visit settings.