Change in flashrom[master]: pcidev.c: Drop unused variable

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/40576 )

Change subject: pcidev.c: Drop unused variable
......................................................................

pcidev.c: Drop unused variable

Change-Id: I6eea3e34ed6fc5d3fe65d5cf7e7bfc5e571bfa73
Signed-off-by: Elyes HAOUAS 
---
M pcidev.c
1 file changed, 1 insertion(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/76/40576/1

diff --git a/pcidev.c b/pcidev.c
index 54c1fd3..e13b78c 100644
--- a/pcidev.c
+++ b/pcidev.c
@@ -189,7 +189,6 @@
    char *msg = NULL;
    int found = 0;
    int i;
-	uintptr_t addr = 0;

if (pci_init_common() != 0)
    	return NULL;
@@ -229,7 +228,7 @@
    		/* FIXME: We should count all matching devices, not
    		 * just those with a valid BAR.
    		 */
-			if ((addr = pcidev_readbar(dev, bar)) != 0) {
+			if (pcidev_readbar(dev, bar) != 0) {
    			found_dev = dev;
    			found++;
    		}

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40576 )

Change subject: pcidev.c: Drop unused variable
......................................................................

Patch Set 1: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40576 )

Change subject: pcidev.c: Drop unused variable
......................................................................

Patch Set 1: Code-Review+1

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40576 )

Change subject: pcidev.c: Drop unused variable
......................................................................

Patch Set 1: Code-Review+2

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/40576 )

Change subject: pcidev.c: Drop unused variable
......................................................................

pcidev.c: Drop unused variable

Change-Id: I6eea3e34ed6fc5d3fe65d5cf7e7bfc5e571bfa73
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/flashrom/+/40576
Tested-by: build bot (Jenkins) 
Reviewed-by: Edward O'Callaghan 
Reviewed-by: Paul Menzel 
Reviewed-by: Angel Pons 
---
M pcidev.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Angel Pons: Looks good to me, approved
  Edward O'Callaghan: Looks good to me, approved

diff --git a/pcidev.c b/pcidev.c
index 54c1fd3..e13b78c 100644
--- a/pcidev.c
+++ b/pcidev.c
@@ -189,7 +189,6 @@
    char *msg = NULL;
    int found = 0;
    int i;
-	uintptr_t addr = 0;

if (pci_init_common() != 0)
    	return NULL;
@@ -229,7 +228,7 @@
    		/* FIXME: We should count all matching devices, not
    		 * just those with a valid BAR.
    		 */
-			if ((addr = pcidev_readbar(dev, bar)) != 0) {
+			if (pcidev_readbar(dev, bar) != 0) {
    			found_dev = dev;
    			found++;
    		}