Edward O'Callaghan submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved
pcidev.c: Drop unused variable

Change-Id: I6eea3e34ed6fc5d3fe65d5cf7e7bfc5e571bfa73
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/40576
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
M pcidev.c
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/pcidev.c b/pcidev.c
index 54c1fd3..e13b78c 100644
--- a/pcidev.c
+++ b/pcidev.c
@@ -189,7 +189,6 @@
char *msg = NULL;
int found = 0;
int i;
- uintptr_t addr = 0;

if (pci_init_common() != 0)
return NULL;
@@ -229,7 +228,7 @@
/* FIXME: We should count all matching devices, not
* just those with a valid BAR.
*/
- if ((addr = pcidev_readbar(dev, bar)) != 0) {
+ if (pcidev_readbar(dev, bar) != 0) {
found_dev = dev;
found++;
}

To view, visit change 40576. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6eea3e34ed6fc5d3fe65d5cf7e7bfc5e571bfa73
Gerrit-Change-Number: 40576
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged