Change in flashrom[master]: [v4, 4/6] ENE EDI - print debug info like others while probing for ENE...
Mike Banon has posted comments on this change. ( https://review.coreboot.org/23261 )
Change subject: [v4,4/6] ENE EDI - print debug info like others while probing for ENE chips ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/#/c/23261/1/edi.c File edi.c:
https://review.coreboot.org/#/c/23261/1/edi.c@154 PS1, Line 154: %i <
It's a signed integer, why print it in hex?
sorry, my mistake
https://review.coreboot.org/#/c/23261/1/edi.c@164 PS1, Line 164: if (chip->hwversion == hwversion && chip->ediid == ediid) {
No need to print them, they are 0 on this path.
indeed. fixed
https://review.coreboot.org/#/c/23261/1/edi.c@169 PS1, Line 169: __func__, hwversion, chip->hwversion, ediid, chip->ediid);
Please add braces here too (they are not required by syntax but help […]
braces added
https://review.coreboot.org/#/c/23261/1/edi.c@171 PS1, Line 171:
Actually, I'm not sure if we want this message at all. This function […]
changed the debug level to msg_cdbg2, hopefully these debug messages will be useful in some cases
-
Mike Banon (Code Review)