View Change

4 comments:

• File edi.c:

  • Patch Set #1, Line 154: %i <

    It's a signed integer, why print it in hex?

    sorry, my mistake

  • Patch Set #1, Line 164: if (chip->hwversion == hwversion && chip->ediid == ediid) {

    No need to print them, they are 0 on this path.

    indeed. fixed

  • Patch Set #1, Line 169: __func__, hwversion, chip->hwversion, ediid, chip->ediid);

    Please add braces here too (they are not required by syntax but help […]

    braces added

  • Patch Set #1, Line 171:

    Actually, I'm not sure if we want this message at all. This function […]

    changed the debug level to msg_cdbg2, hopefully these debug messages will be useful in some cases

To view, visit change 23261. To unsubscribe, or for help writing mail filters, visit settings.