Attention is currently required from: Nico Huber, Thomas Heijligen, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57918 )
Change subject: tests: Add init-shutdown test for raiden_debug_spi ......................................................................
Patch Set 7:
(1 comment)
File tests/init_shutdown.c:
https://review.coreboot.org/c/flashrom/+/57918/comment/2b44bf12_869c237f PS6, Line 57: ss
Hmmm, usually we have the compiler warn about it (missing-prototype?). […]
As I understand Edward's comment, I marked all these raiden functions static - they are, yes.
Re: meson warnings. In general, I noticed they are not blocking, tests can run when code has warnings. I thought this is a feature, not a bug... For me it is useful when debugging, I can quickly throw in few sloppy printf statements and run tests, or comment chunk of code and run tests.
Specifically here, there were no warnings about raiden functions. But CONFIG_RAIDEN_DEBUG_SPI is enabled by default, maybe that's why?
And even more global question, about switching away from meson for tests, there is a lot to think about. But we do need to think about it, yes.
-
Anastasia Klimchuk (Code Review)