Attention is currently required from: Nico Huber, Thomas Heijligen, Edward O'Callaghan, Angel Pons.

View Change

1 comment:

• File tests/init_shutdown.c:

  • Patch Set #6, Line 57: ss

    Hmmm, usually we have the compiler warn about it (missing-prototype?). […]

    As I understand Edward's comment, I marked all these raiden functions static - they are, yes.

    Re: meson warnings. In general, I noticed they are not blocking, tests can run when code has warnings. I thought this is a feature, not a bug... For me it is useful when debugging, I can quickly throw in few sloppy printf statements and run tests, or comment chunk of code and run tests.

    Specifically here, there were no warnings about raiden functions. But CONFIG_RAIDEN_DEBUG_SPI is enabled by default, maybe that's why?

    And even more global question, about switching away from meson for tests, there is a lot to think about. But we do need to think about it, yes.

To view, visit change 57918. To unsubscribe, or for help writing mail filters, visit settings.