Attention is currently required from: Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58561 )
Change subject: Add -W options from Makefile into meson warning_flags ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
I think the intention here by meson is to decouple a little from compiler specific frontend flags from meaning.
Yes that probably what it the intention is, but, it seems like docs are too vague, the only thing official docs say is (quote from https://mesonbuild.com/Builtin-options.html#core-options):
Set the warning level. From 0 = none to 3 = highest
It is hard to make a decision about warning based on just this little bit of information, especially unclear is what level 1 and 2 mean. Like one can say: okay, none is no warnings, 3 is all possible warnings, but what is 1 and 2 ? :)
Anyways, our current level is 2.
-
Anastasia Klimchuk (Code Review)