Attention is currently required from: Thomas Heijligen.
View Change
1 comment:
Patchset:
Patch Set #2:
I think the intention here by meson is to decouple a little from compiler specific frontend flags from meaning.
Yes that probably what it the intention is, but, it seems like docs are too vague, the only thing official docs say is (quote from https://mesonbuild.com/Builtin-options.html#core-options):
> Set the warning level. From 0 = none to 3 = highest
It is hard to make a decision about warning based on just this little bit of information, especially unclear is what level 1 and 2 mean. Like one can say: okay, none is no warnings, 3 is all possible warnings, but what is 1 and 2 ? :)
Anyways, our current level is 2.
To view, visit change 58561. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id401bfd642dc3c13d85bd9a2dba56ada38714c25
Gerrit-Change-Number: 58561
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Peter Marheine <pmarheine@chromium.org>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Comment-Date: Wed, 13 Apr 2022 05:03:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen <src@posteo.de>
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment