Change in flashrom[master]: enum programmer: replace by size_t - flashrom-gerrit

6 Jun 2021


      Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55120 )
Change subject: enum programmer: replace by size_t
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Patchset:
PS4: 
I would prefer `unsigned int` instead, but have no strong feelings
about it. I've myself used `size_t` as index type in the past just
because it's more convenient to type :) but technically, it's
reserved for byte indices.
(The whole story is inconsistent because our definition of
ARRAY_SIZE() implies size_t. Maybe that's something that should
change?)
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/55120
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id2ad9630fbc41e98d182768b553788e069fa5095
Gerrit-Change-Number: 55120
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Xiang W wxjstz@126.com
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Sun, 06 Jun 2021 12:25:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment