Alan Green has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/35535 )
Change subject: flashchips.c: Mark W25Q40EW as TESTED_PREW ......................................................................
flashchips.c: Mark W25Q40EW as TESTED_PREW
Mark Winbond W25Q40EW as TESTED_PREW.
The Winbond W25Q40EW has been marked TESTED_PREW in the ChromiumOS repository. ChromiumOS has the same defintion for this chip as this repo, except that ChromiumOS does not have FEATURE_OTP.
Signed-off-by: Alan Green avg@google.com Change-Id: I4be5b2e1069a3f735f0dc6ec92d5f4c8946fbb02 --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/35/35535/1
diff --git a/flashchips.c b/flashchips.c index 0502b86..7635942 100644 --- a/flashchips.c +++ b/flashchips.c @@ -16231,7 +16231,7 @@ .page_size = 256, /* OTP: 3*256B total; read 0x48; write 0x42, erase 0x44, read ID 0x4B */ .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers =
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35535 )
Change subject: flashchips.c: Mark W25Q40EW as TESTED_PREW ......................................................................
Patch Set 1: Code-Review+2
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/35535 )
Change subject: flashchips.c: Mark W25Q40EW as TESTED_PREW ......................................................................
flashchips.c: Mark W25Q40EW as TESTED_PREW
Mark Winbond W25Q40EW as TESTED_PREW.
The Winbond W25Q40EW has been marked TESTED_PREW in the ChromiumOS repository. ChromiumOS has the same defintion for this chip as this repo, except that ChromiumOS does not have FEATURE_OTP.
Signed-off-by: Alan Green avg@google.com Change-Id: I4be5b2e1069a3f735f0dc6ec92d5f4c8946fbb02 Reviewed-on: https://review.coreboot.org/c/flashrom/+/35535 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Edward O'Callaghan quasisec@chromium.org --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved
diff --git a/flashchips.c b/flashchips.c index e6215a0..8baa2ee 100644 --- a/flashchips.c +++ b/flashchips.c @@ -16230,7 +16230,7 @@ .page_size = 256, /* OTP: 3*256B total; read 0x48; write 0x42, erase 0x44, read ID 0x4B */ .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers =
-
Alan Green (Code Review) -
Edward O'Callaghan (Code Review)