Alan Green has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/35549 )
Change subject: flashchips.c: Add W25Q128.V..M printlock attribute ......................................................................
flashchips.c: Add W25Q128.V..M printlock attribute
Add a printlock attribute for the Winbond W25Q128.V..M chip. The printlock attributes matches the ChromiumOS repo's definition of this chip.
Signed-off-by: Alan Green avg@google.com Change-Id: I775d5d40677593dcb2d05750f8bbc62871b0e551 --- M flashchips.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/49/35549/1
diff --git a/flashchips.c b/flashchips.c index 8baa2ee..7635942 100644 --- a/flashchips.c +++ b/flashchips.c @@ -15807,6 +15807,7 @@ .block_erase = spi_block_erase_c7, } }, + .printlock = spi_prettyprint_status_register_plain, .unlock = spi_disable_blockprotect, .write = spi_chip_write_256, .read = spi_chip_read,
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35549 )
Change subject: flashchips.c: Add W25Q128.V..M printlock attribute ......................................................................
Patch Set 1: Code-Review+2
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/35549 )
Change subject: flashchips.c: Add W25Q128.V..M printlock attribute ......................................................................
flashchips.c: Add W25Q128.V..M printlock attribute
Add a printlock attribute for the Winbond W25Q128.V..M chip. The printlock attributes matches the ChromiumOS repo's definition of this chip.
Signed-off-by: Alan Green avg@google.com Change-Id: I775d5d40677593dcb2d05750f8bbc62871b0e551 Reviewed-on: https://review.coreboot.org/c/flashrom/+/35549 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Edward O'Callaghan quasisec@chromium.org --- M flashchips.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved
diff --git a/flashchips.c b/flashchips.c index 8baa2ee..7635942 100644 --- a/flashchips.c +++ b/flashchips.c @@ -15807,6 +15807,7 @@ .block_erase = spi_block_erase_c7, } }, + .printlock = spi_prettyprint_status_register_plain, .unlock = spi_disable_blockprotect, .write = spi_chip_write_256, .read = spi_chip_read,
-
Alan Green (Code Review) -
Edward O'Callaghan (Code Review)