Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Michael Niewöhner, Sergii Dmytruk. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55715 )
Change subject: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops ......................................................................
Patch Set 21:
(6 comments)
File ite_ecfw.c:
https://review.coreboot.org/c/flashrom/+/55715/comment/fa9d95ba_76180c87 PS17, Line 835: : if (register_shutdown(ite_ecfw_shutdown, ctx_data)) : goto ite_ecfw_init_exit; :
Or do we know any other way of getting out of flashing mode of the EC? […]
Done
File ite_ecfw.c:
https://review.coreboot.org/c/flashrom/+/55715/comment/241321b5_6a0d5538 PS20, Line 87: crc_check
this bit is inverted (1 = disable); change the name to `no_crc_check`? […]
Done
https://review.coreboot.org/c/flashrom/+/55715/comment/d7a907de_cb2a0681 PS20, Line 87: enables
disables
Done
https://review.coreboot.org/c/flashrom/+/55715/comment/49a73010_46f02acd PS20, Line 91: fspi_mirror
this bit is negated (1 = disable), change the name to `no_fspi_mirror`? […]
Done
https://review.coreboot.org/c/flashrom/+/55715/comment/0c58f278_fd1cc552 PS20, Line 93: pwm_blinking
this bit is negated (1 = disable); change the name to `no_pwm_blinking`? […]
Done
https://review.coreboot.org/c/flashrom/+/55715/comment/58ca6021_ad215108 PS20, Line 332: if (blocks_1_2) { : itestring->flags.clock_source = CLOCK_SOURCE_INTERNAL; :
hm, I know the reference implementation does that... […]
The question is if we remove it will not break things?