Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Michael Niewöhner, Sergii Dmytruk.

View Change

6 comments:

• File ite_ecfw.c:

  • Patch Set #17, Line 835:

    
    	if (register_shutdown(ite_ecfw_shutdown, ctx_data))
    		goto ite_ecfw_init_exit;
    
    

    > Or do we know any other way of getting out of flashing mode of the EC? […]

    Done

• File ite_ecfw.c:

  • Patch Set #20, Line 87: crc_check

    this bit is inverted (1 = disable); change the name to `no_crc_check`? […]

    Done

  • Patch Set #20, Line 87: enables

    disables

    Done

  • Patch Set #20, Line 91: fspi_mirror

    this bit is negated (1 = disable), change the name to `no_fspi_mirror`? […]

    Done

  • Patch Set #20, Line 93: pwm_blinking

    this bit is negated (1 = disable); change the name to `no_pwm_blinking`? […]

    Done

  • Patch Set #20, Line 332:

    		if (blocks_1_2) {
    			itestring->flags.clock_source = CLOCK_SOURCE_INTERNAL;
    
    

    hm, I know the reference implementation does that... […]

    The question is if we remove it will not break things?

To view, visit change 55715. To unsubscribe, or for help writing mail filters, visit settings.