Attention is currently required from: Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72619 )
Change subject: move manpage to sphinx ......................................................................
Patch Set 7: Code-Review+1
(6 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/72619/comment/ddf27926_0a7245b1 PS7, Line 12: ... maybe remove the ellipsis? and also in the other command next to this
https://review.coreboot.org/c/flashrom/+/72619/comment/02fc2fe1_000ef1cc PS7, Line 14: sphix-build typo sphix-build -> sphinx-build
https://review.coreboot.org/c/flashrom/+/72619/comment/cae9f2ab_a3d56f34 PS7, Line 14: automaticly typo automaticly -> automatically
https://review.coreboot.org/c/flashrom/+/72619/comment/1050326f_9fa47a69 PS7, Line 16: The install paths are `share/man/man8/flashrom.8` and : `share/doc/flashrom/index.html` : : The Makefile builds only the man-page format. I am wondering, do we need to add this info to README (or to meson build documentation)? Specifically: 1) man page and documentation are built automatically when sphinx-build is found 2) install paths for those 3) Makefile only builds man page
Patchset:
PS7: I have just few small things. This looks great, and thank you so much for a lot of work for converting that long man page into new format!
File meson_options.txt:
https://review.coreboot.org/c/flashrom/+/72619/comment/1f6d05cc_8c00ca81 PS7, Line 21: man-pages That's a small thing, but are we ever going to have multiple man pages? The option is "pages", plural, but we have just one man-page ?
-
Anastasia Klimchuk (Code Review)