Attention is currently required from: Thomas Heijligen.

Patch set 7:Code-Review +1

6 comments:

Commit Message:
- Patch Set #7, Line 12: ...
  maybe remove the ellipsis? and also in the other command next to this
- Patch Set #7, Line 14: sphix-build
  typo
  sphix-build -> sphinx-build
- Patch Set #7, Line 14: automaticly
  typo
  automaticly -> automatically
- Patch Set #7, Line 16:
```
The install paths are `share/man/man8/flashrom.8` and
`share/doc/flashrom/index.html`

The Makefile builds only the man-page format.
```
  I am wondering, do we need to add this info to README (or to meson build documentation)?
  Specifically:
  1) man page and documentation are built automatically when sphinx-build is found
  2) install paths for those
  3) Makefile only builds man page
Patchset:
- Patch Set #7:
  I have just few small things.
  This looks great, and thank you so much for a lot of work for converting that long man page into new format!
File meson_options.txt:
- Patch Set #7, Line 21: man-pages
  That's a small thing, but are we ever going to have multiple man pages? The option is "pages", plural, but we have just one man-page ?

To view, visit change 72619. To unsubscribe, or for help writing mail filters, visit settings.