Attention is currently required from: Nico Huber, Angel Pons. Thomas Walker has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52310 )
Change subject: flashchips: Add Spansion/Cypress S25FL256L ......................................................................
Patch Set 3:
(9 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/52310/comment/d1e115b2_b4fc578d PS1, Line 7: Added support for Spansion/Cypress chip S25FL256L.
Commit messages are written in present tense, do not end with a period and usually have a prefix. […]
Done
https://review.coreboot.org/c/flashrom/+/52310/comment/280e510d_abd2482c PS1, Line 9: Testing has been conducted on ~60 individual chips and confirmed as working.
One thing about write tests: flashrom compares the current contents of the flash chip to the provide […]
I wont provide the full log of the random write test, however I have confirmed that it worked correctly and stated VERIFIED at the end.
Patchset:
PS1:
Welcome!
Thank you, I'm pretty new to contributing to public repositories, and this review process is a little daunting, so forgive me for my mistakes!
Patchset:
PS3: Changes made as per Angel's suggestions.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/52310/comment/40522d42_ee2ef3aa PS1, Line 16387: |
Please add spaces around `|`
Done
https://review.coreboot.org/c/flashrom/+/52310/comment/1249e735_5e51ca8c PS1, Line 16391: .block_erasers =
Many block erasers are missing, and only the first entry is correct. […]
Added spi_block_erase_53, let me know if there are any corrections that need to be made.
https://review.coreboot.org/c/flashrom/+/52310/comment/98fafb0d_5e60d641 PS1, Line 16401: spi_prettyprint_status_register_plain
spi_prettyprint_status_register_bp3_srwd
Done
https://review.coreboot.org/c/flashrom/+/52310/comment/7e51e5b6_08229493 PS1, Line 16402: spi_disable_blockprotect
spi_disable_blockprotect_bp3_srwd
Done
https://review.coreboot.org/c/flashrom/+/52310/comment/e026d2f7_4a143e1d PS1, Line 16406: },
Please use tabs for indentation
Done
-
Thomas Walker (Code Review)