Attention is currently required from: Nico Huber, Angel Pons.
9 comments:
Commit Message:
Patch Set #1, Line 7: Added support for Spansion/Cypress chip S25FL256L.
Commit messages are written in present tense, do not end with a period and usually have a prefix. […]
Done
Patch Set #1, Line 9: Testing has been conducted on ~60 individual chips and confirmed as working.
One thing about write tests: flashrom compares the current contents of the flash chip to the provide […]
I wont provide the full log of the random write test, however I have confirmed that it worked correctly and stated VERIFIED at the end.
Patchset:
Welcome!
Thank you, I'm pretty new to contributing to public repositories, and this review process is a little daunting, so forgive me for my mistakes!
Patchset:
Changes made as per Angel's suggestions.
File flashchips.c:
Please add spaces around `|`
Done
Patch Set #1, Line 16391: .block_erasers =
Many block erasers are missing, and only the first entry is correct. […]
Added spi_block_erase_53, let me know if there are any corrections that need to be made.
Patch Set #1, Line 16401: spi_prettyprint_status_register_plain
spi_prettyprint_status_register_bp3_srwd
Done
Patch Set #1, Line 16402: spi_disable_blockprotect
spi_disable_blockprotect_bp3_srwd
Done
Please use tabs for indentation
Done
To view, visit change 52310. To unsubscribe, or for help writing mail filters, visit settings.