Attention is currently required from: Peter Marheine.
Anastasia Klimchuk has posted comments on this change by Peter Marheine. ( https://review.coreboot.org/c/flashrom/+/86350?usp=email )
Change subject: doc: autogenerate a list of authors and hall of fame ......................................................................
Patch Set 11:
(5 comments)
Patchset:
PS11: This is going great! I am so so so happy 😊
Let's add to `/release_notes/devel` !
File doc/about_flashrom/hall_of_fame.rst:
https://review.coreboot.org/c/flashrom/+/86350/comment/a8f0dc57_a3841b5d?usp... : PS11, Line 9: code reviewers maybe let's just say "reviewers" ? one word for each section
https://review.coreboot.org/c/flashrom/+/86350/comment/91edc790_b78c9b20?usp... : PS11, Line 21: ======= I am curious, this is 7 chars, and in the same situation on the Contact page we had to add one more extra `=` chat so that git won't confuse this with conflict marker. (see lines 2-4 here https://github.com/flashrom/flashrom/blob/main/doc/contact.rst?plain=1)
But, I downloaded the patch locally, and there is no warning from git! I am wondering why :)
File doc/about_flashrom/index.rst:
https://review.coreboot.org/c/flashrom/+/86350/comment/d53d61d2_4b9c0029?usp... : PS11, Line 10: hall_of_fame I would put it #2 in the list, after Team
In general, I think CoC and privacy can be always the last in the list
File doc/collect-authors.sh:
https://review.coreboot.org/c/flashrom/+/86350/comment/f6725556_8863b650?usp... : PS11, Line 11: Co-Authored-by Can we also add `Co-developed-by` ? in addition to `Co-Authored-by`
In the recent patches, it was mostly `Co-developed-by`. However, both tags are valid, and I haven't looked through full history, so I assume both can be used.
-
Anastasia Klimchuk (Code Review)