Attention is currently required from: Peter Marheine.
5 comments:
Patchset:
This is going great! I am so so so happy 😊
Let's add to `/release_notes/devel` !
File doc/about_flashrom/hall_of_fame.rst:
Patch Set #11, Line 9: code reviewers
maybe let's just say "reviewers" ? one word for each section
Patch Set #11, Line 21: =======
I am curious, this is 7 chars, and in the same situation on the Contact page we had to add one more extra `=` chat so that git won't confuse this with conflict marker.
(see lines 2-4 here https://github.com/flashrom/flashrom/blob/main/doc/contact.rst?plain=1)
But, I downloaded the patch locally, and there is no warning from git! I am wondering why :)
File doc/about_flashrom/index.rst:
Patch Set #11, Line 10: hall_of_fame
I would put it #2 in the list, after Team
In general, I think CoC and privacy can be always the last in the list
File doc/collect-authors.sh:
Patch Set #11, Line 11: Co-Authored-by
Can we also add `Co-developed-by` ? in addition to `Co-Authored-by`
In the recent patches, it was mostly `Co-developed-by`.
However, both tags are valid, and I haven't looked through full history, so I assume both can be used.
To view, visit change 86350. To unsubscribe, or for help writing mail filters, visit settings.