Attention is currently required from: Patrick Rudolph.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/78302?usp=email )
Change subject: dmi: Scan in sysfs first ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/78302/comment/c6c8c767_22307b27 : PS2, Line 12: Needs tests on internal programmer A comment, not to forget this
File dmi.c:
https://review.coreboot.org/c/flashrom/+/78302/comment/1669a484_c6a6b539 : PS2, Line 48: #define LINUX_DMI_SYSFS_TABLE_3 "/sys/firmware/dmi/entries/3-0/raw" Can this also go under `#if !IS_WINDOWS` ?
https://review.coreboot.org/c/flashrom/+/78302/comment/59d3f2a0_13640934 : PS2, Line 448: #if !IS_WINDOWS Maybe you can create a function which checks `#if !IS_WINDOWS` inside, and does nothing for windows case? And here you can call it. For example `scan_dmi_table`, or some other name. That would be less of pre-processor instructions.