Attention is currently required from: Patrick Rudolph.

View Change

3 comments:

• Commit Message:

  • Patch Set #2, Line 12: Needs tests on internal programmer

    A comment, not to forget this

• File dmi.c:

  • Patch Set #2, Line 48: #define LINUX_DMI_SYSFS_TABLE_3 "/sys/firmware/dmi/entries/3-0/raw"

    Can this also go under `#if !IS_WINDOWS` ?

  • Patch Set #2, Line 448: #if !IS_WINDOWS

    Maybe you can create a function which checks `#if !IS_WINDOWS` inside, and does nothing for windows case? And here you can call it. For example `scan_dmi_table`, or some other name.
    That would be less of pre-processor instructions.

To view, visit change 78302. To unsubscribe, or for help writing mail filters, visit settings.