Attention is currently required from: Michał Żygowski, ?ukasz Dmitrowski, David Hendricks, Thomas Heijligen, Angel Pons, Piotr Król.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55350 )
Change subject: libflashrom: remove flashrom_supported_programmers
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/55350/comment/4e369ad7_8d18041e
PS1, Line 9: const char **flashrom_supported_programmers(void) returns an array of
: strings without returning the array size or making a NULL
: termination.
CB:55269 happens to NULL-terminate the returned array.
It does, but I would still like to get rid of this API. There are other
issues, e.g. the complementary flashrom_data_free() is designed such
that only a single implementation is possible. Beside making future
changes harder, it indirectly leaks information about libflashrom
internals.
Given that it was broken all the time, I assume nobody is using it,
so I guess it would be best to drop it before anybody does.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/55350
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0157926a654e337c14d840dd398e5576471c304f
Gerrit-Change-Number: 55350
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: ?ukasz Dmitrowski
lukasz.dmitrowski@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: ?ukasz Dmitrowski
lukasz.dmitrowski@gmail.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Comment-Date: Wed, 09 Jun 2021 15:16:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment