Attention is currently required from: Michał Żygowski, ?ukasz Dmitrowski, David Hendricks, Thomas Heijligen, Angel Pons, Piotr Król.

View Change

1 comment:

• Commit Message:

  • Patch Set #1, Line 9:

    const char **flashrom_supported_programmers(void) returns an array of
    strings without returning the array size or making a NULL
    termination.
    

    CB:55269 happens to NULL-terminate the returned array.

    It does, but I would still like to get rid of this API. There are other
    issues, e.g. the complementary flashrom_data_free() is designed such
    that only a single implementation is possible. Beside making future
    changes harder, it indirectly leaks information about libflashrom
    internals.

    Given that it was broken all the time, I assume nobody is using it,
    so I guess it would be best to drop it before anybody does.

To view, visit change 55350. To unsubscribe, or for help writing mail filters, visit settings.