Attention is currently required from: Michał Żygowski, Jonathan Zhang, David Hendricks, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57793 )
Change subject: ich_descriptors: Add explicit checks for all chipsets ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/57793/comment/2e2a978a_2fffe480 PS1, Line 9: CB:55651 Please reference merged commits by their commit hash, e.g.
commit cd9b7b427 (ich_descriptors: Normalize chipset detection)
This way, one doesn't need Gerrit or a manual search to find it.
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/57793/comment/3f291eb1_b1cd7cb7 PS1, Line 962: warn_peculiar_desc(content->ICCRIBA > 0x34, "C620 series"); Another case,
https://review.coreboot.org/c/flashrom/+/57793/comment/ef44f561_a562c5d0 PS1, Line 965: warn_peculiar_desc(content->ICCRIBA != 0x31, "100 series"); and another one. Basically, if there is an expression given as the first argument to warn_peculiar_desc(), it's an explicit `if` missing. When these arguments are all `true`, we won't need the `warn_if` parameter anymore.