Attention is currently required from: Michał Żygowski, Jonathan Zhang, David Hendricks, Angel Pons.

View Change

3 comments:

• Commit Message:

  • Patch Set #1, Line 9: CB:55651

    Please reference merged commits by their commit hash, e.g.

        commit cd9b7b427 (ich_descriptors: Normalize chipset detection)

    This way, one doesn't need Gerrit or a manual search to find it.

• File ich_descriptors.c:

  • Patch Set #1, Line 962: warn_peculiar_desc(content->ICCRIBA > 0x34, "C620 series");

    Another case,

  • Patch Set #1, Line 965: warn_peculiar_desc(content->ICCRIBA != 0x31, "100 series");

    and another one. Basically, if there is an expression given as the first
    argument to warn_peculiar_desc(), it's an explicit `if` missing. When these
    arguments are all `true`, we won't need the `warn_if` parameter anymore.

To view, visit change 57793. To unsubscribe, or for help writing mail filters, visit settings.