[S] Change in flashrom[master]: programmer: Add get_region to spi/opaque masters - flashrom-gerrit

30 Nov 2022


      Attention is currently required from: Angel Pons, Nikolai Artemiev.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70126 )
Change subject: programmer: Add get_region to spi/opaque masters
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File include/programmer.h:
https://review.coreboot.org/c/flashrom/+/70126/comment/36cc62e1_312bf466 
PS2, Line 291: /* TODO: integrate/deduplicate with layout data structures. */
How about including CB:69196 in your series without the two `bool R|W_prot` fields and changing *this* patch on top just to include the two `bool R|W_prot` fields in the struct so the comment in CB:69196 can be resolved.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/70126
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8c43f6b705f36ef18842a04ba6241d3a0b36b232
Gerrit-Change-Number: 70126
Gerrit-PatchSet: 2
Gerrit-Owner: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Nikolai Artemiev nartemiev@google.com
Gerrit-Comment-Date: Wed, 30 Nov 2022 23:05:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment