[M] Change in flashrom[master]: ichspi: Expose flash descriptor regions through get_region()

[Edward O'Callaghan (Code Review)]

Attention is currently required from: Nikolai Artemiev.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70127 )

Change subject: ichspi: Expose flash descriptor regions through get_region()
......................................................................


Patch Set 3:

(5 comments)

Commit Message:

https://review.coreboot.org/c/flashrom/+/70127/comment/3f3ee6a2_5f743f85 
PS3, Line 24: TEST=todo
with this patch focused more on just the hwseq path it will make the testing easier.


File ichspi.c:

https://review.coreboot.org/c/flashrom/+/70127/comment/77171c68_2d50b803 
PS3, Line 300: static struct fd_region fd_regions[MAX_FD_REGIONS] = {{0}};
put this inside `struct hwseq_data`


https://review.coreboot.org/c/flashrom/+/70127/comment/9e1c9e76_aa8116fd 
PS3, Line 1158:  fd_regions
fetch this out of the master's opaque data field.


https://review.coreboot.org/c/flashrom/+/70127/comment/84c4bdcf_c7419677 
PS3, Line 1853: fd_regions
pass a reference to this in as a argument to the function.


https://review.coreboot.org/c/flashrom/+/70127/comment/c3c284bf_ed91e7e3 
PS3, Line 1940: 	.get_region	= ich_get_region,
Add support for non-hwseq mode in a seperate patch.



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/70127
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I019f3f407f6a2a82f686a168457e0e32961ff483
Gerrit-Change-Number: 70127
Gerrit-PatchSet: 3
Gerrit-Owner: Nikolai Artemiev <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Attention: Nikolai Artemiev <[e-mail]>
Gerrit-Comment-Date: Wed, 30 Nov 2022 23:00:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment