Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56825 )
Change subject: opaque_master: Use new API to register shutdown function
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File linux_mtd.c:
https://review.coreboot.org/c/flashrom/+/56825/comment/445c183d_d4b32a7b
PS1, Line 421: if (register_shutdown(linux_mtd_shutdown, (void *)data)) {
Looks like this is also fixing leakage of a file descriptor.
File nicintel_eeprom.c:
https://review.coreboot.org/c/flashrom/+/56825/comment/254d6472_4efc3b3c
PS1, Line 497:
: return register_opaque_master(&opaque_master_nicintel_ee_82580, eecp);
The piece of data, eecp, is only used in shutdown function, and not used as opaque_master data (prev […]
Sounds correct.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/56825
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id8471a117556edcbf9694752fabe05cf4501ce70
Gerrit-Change-Number: 56825
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Tue, 17 Aug 2021 16:28:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment