Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
Patch set 1:Code-Review +1
View Change
2 comments:
File linux_mtd.c:
Patch Set #1, Line 421: if (register_shutdown(linux_mtd_shutdown, (void *)data)) {
Looks like this is also fixing leakage of a file descriptor.
File nicintel_eeprom.c:
Patch Set #1, Line 497:
return register_opaque_master(&opaque_master_nicintel_ee_82580, eecp);
The piece of data, eecp, is only used in shutdown function, and not used as opaque_master data (prev […]
Sounds correct.
To view, visit change 56825. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id8471a117556edcbf9694752fabe05cf4501ce70
Gerrit-Change-Number: 56825
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Tue, 17 Aug 2021 16:28:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment