Attention is currently required from: Patrick Rudolph. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63135 )
Change subject: linux_mtd: Allow to open parition by name ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File linux_mtd.c:
https://review.coreboot.org/c/flashrom/+/63135/comment/5d1d5a8a_18298a6d PS1, Line 464: extract_programmer_param("name");
I thought it's already mutually exclusive as extract_programmer_param("name"); is in the else branch. I did not reuse the existing dev as a partition label might contain digits only. In that case you'd not know if the number is the MTD device or the label.
I see, thanks for explaining.
It's mutually exclusive at runtime but it won't complain if you provide both "name" and "dev". We don't check for other meaningless programmer params so that's fine.
-
Arthur Heymans (Code Review)