Attention is currently required from: Patrick Rudolph.
Patch set 1:Code-Review +2
View Change
1 comment:
File linux_mtd.c:
Patch Set #1, Line 464: extract_programmer_param("name");
I thought it's already mutually exclusive as extract_programmer_param("name"); is in the else branch.
I did not reuse the existing dev as a partition label might contain digits only. In that case you'd not know if the number is the MTD device or the label.
I see, thanks for explaining.
It's mutually exclusive at runtime but it won't complain if you provide both "name" and "dev". We don't check for other meaningless programmer params so that's fine.
To view, visit change 63135. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I566b9809950cbf47fbb01ae89305641c4e259f68
Gerrit-Change-Number: 63135
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Attention: Patrick Rudolph <siro@das-labor.org>
Gerrit-Comment-Date: Mon, 28 Mar 2022 12:17:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Arthur Heymans <arthur@aheymans.xyz>
Comment-In-Reply-To: Patrick Rudolph <siro@das-labor.org>
Gerrit-MessageType: comment