Attention is currently required from: Felix Singer, Thomas Heijligen. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57889 )
Change subject: ch341a_spi: libusb functions can handle all platforms ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/57889/comment/b44df413_4d84e56f PS1, Line 7: libusb functions can handle all platforms This should be a statement about the code change, e.g.
Call libusb_detach_kernel_driver() on all platforms
File ch341a_spi.c:
https://review.coreboot.org/c/flashrom/+/57889/comment/57e5f92d_df2a2c3c PS1, Line 450: Other platforms return How about "Other platforms may return..."?
https://review.coreboot.org/c/flashrom/+/57889/comment/0006100a_91b0ff22 PS1, Line 450: /* libusb_detach_kernel_driver() is only available on linux. Other platforms return : * LIBUSB_ERROR_NOT_SUPPORTED. That's fine. */ Please indent, it was only at level 0 because of the #if there.
-
Nico Huber (Code Review)