Attention is currently required from: Felix Singer, Thomas Heijligen.

Patch set 1:Code-Review +1

View Change

3 comments:

• Commit Message:

  • Patch Set #1, Line 7: libusb functions can handle all platforms

    This should be a statement about the code change, e.g.

        Call libusb_detach_kernel_driver() on all platforms

• File ch341a_spi.c:

  • Patch Set #1, Line 450: Other platforms return

    How about "Other platforms may return..."?

  • Patch Set #1, Line 450:

    /* libusb_detach_kernel_driver() is only available on linux. Other platforms return
     * LIBUSB_ERROR_NOT_SUPPORTED. That's fine. */
    

    Please indent, it was only at level 0 because of the #if there.

To view, visit change 57889. To unsubscribe, or for help writing mail filters, visit settings.